feat: store kube config file to make buildx builder switchable #497
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
morlay
force-pushed
the
k8s-driver-configuration-bind
branch
from
095da6a
to
5d50a15
Compare
AkihiroSuda
reviewed
Dec 30, 2020
AkihiroSuda
reviewed
Dec 30, 2020
morlay
force-pushed
the
k8s-driver-configuration-bind
branch
2 times, most recently
from
a339e41
to
26fa4fc
Compare
Signed-off-by: Wang <morlay.null@gmail.com>
morlay
force-pushed
the
k8s-driver-configuration-bind
branch
from
26fa4fc
to
68cebff
Compare
AkihiroSuda
approved these changes
Dec 30, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
issue from slack by David Giffin
failed use docker context, the auth way not support only
username&password(https://github.com/docker/cli/blob/master/cli/context/kubernetes/load.go#L73-L74),which will break other auth ways like
client-key&client-cert.just added query parameter config-file (from
KUBECONFIGwhen builder created). and dynamic load kube config when use the kubernetes builder.