Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Duplicated progress env var #693

Merged
merged 1 commit into from
Jul 25, 2021
Merged

Conversation

crazy-max
Copy link
Member

@crazy-max crazy-max commented Jul 25, 2021

This PR reverts BUILDX_PROGRESS_DEFAULT env var that was introduced in #504 because it was already available through #69 with BUILDKIT_PROGRESS env var.

Docs have also been updated as stipulated in #62 (comment)

Signed-off-by: CrazyMax crazy-max@users.noreply.github.com

Signed-off-by: CrazyMax <crazy-max@users.noreply.github.com>
@crazy-max crazy-max requested a review from thaJeztah July 25, 2021 10:41
Copy link
Member

@thaJeztah thaJeztah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, looks like it was not yet in use by anyone 🤞https://grep.app/search?q=BUILDX_PROGRESS_DEFAULT

@crazy-max
Copy link
Member Author

@thaJeztah

looks like it was not yet in use by anyone

Yes hopefully :)

@thaJeztah
Copy link
Member

Perhaps we should add a section related to build env-vars in https://github.com/docker/cli/blob/master/docs/reference/commandline/cli.md#environment-variables

(also make sure that docker build without buildx supports this)

@crazy-max
Copy link
Member Author

@thaJeztah

Perhaps we should add a section related to build env-vars

Done docker/cli#3208

I think we should also mutualize the progress package in a follow-up:

@crazy-max crazy-max merged commit 5daf176 into docker:master Jul 25, 2021
@crazy-max crazy-max deleted the buildkit-progress branch July 25, 2021 20:18
@thaJeztah
Copy link
Member

I think we should also mutualize the progress package in a follow-up:

Possibly yes; but I see the buildkit version has more subpackages. Haven't looked closely yet, but if you do so, be sure check that it doesn't bring complexity and/or dependencies that are not desirable here.

@crazy-max crazy-max added this to the v0.6.1 milestone Jul 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants