Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set ConfigFile to parse compose files with bake #704

Merged
merged 1 commit into from
Jul 30, 2021
Merged

Set ConfigFile to parse compose files with bake #704

merged 1 commit into from
Jul 30, 2021

Conversation

crazy-max
Copy link
Member

Fixes #703

Signed-off-by: CrazyMax crazy-max@users.noreply.github.com

@crazy-max
Set ConfigFile to parse compose files with bake
9aa8f09 
Signed-off-by: CrazyMax <crazy-max@users.noreply.github.com>
@crazy-max crazy-max marked this pull request as ready for review July 30, 2021 16:05
thaJeztah
thaJeztah approved these changes Jul 30, 2021
View reviewed changes
Copy link
Member

@thaJeztah thaJeztah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SGTM (but I'm not super familiar with the compose-spec code, so I trust @ndeloof on this one)

@crazy-max crazy-max merged commit 260d07a into docker:master Jul 30, 2021
@crazy-max crazy-max deleted the use-compose-config-file branch July 30, 2021 16:35
@crazy-max crazy-max added this to the v0.6.1 milestone Jul 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ndeloof ndeloof ndeloof approved these changes

@thaJeztah thaJeztah thaJeztah approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v0.6.1
Development

Successfully merging this pull request may close these issues.

docker buildx bake handles environment variables as arguments differently in v0.6.0
3 participants
@crazy-max @ndeloof @thaJeztah