Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow Docker to ship buildx guarded by the experimental flag #81

Merged
merged 1 commit into from
May 23, 2019

Conversation

tiborvass
Copy link
Collaborator

@tiborvass tiborvass commented May 23, 2019

Discussion in docker/cli#1898 and docker/cli#1897

To guard this Docker CLI plugin with docker's experimental CLI config, buildx needs to be built with go build -ldflags "-X main.experimental=1"

@tiborvass tiborvass changed the title Experimental Allow Docker to ship buildx guarded by the experimental flag May 23, 2019
To guard this Docker CLI plugin with docker's experimental CLI config,
buildx needs to be built with `go build -ldflags "-X main.experimental=1"`

Signed-off-by: Tibor Vass <tibor@docker.com>
Copy link
Member

@thaJeztah thaJeztah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@andrewhsu
Copy link

cc @seemethere

Copy link

@andrewhsu andrewhsu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tiborvass tiborvass merged commit 4e61674 into docker:master May 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants