Merge pull request #1795 from thaJeztah/18.09_backport_dialstdio_1736

[18.09 backport] dial-stdio: fix goroutine leakage
docker · Apr 2, 2019 · c89750f · c89750f
2 parents c805ad2 + d8c6c83
commit c89750f
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/cli/command/system/dial_stdio.go b/cli/command/system/dial_stdio.go
@@ -46,8 +46,8 @@ func runDialStdio(dockerCli command.Cli) error {
 		return errors.New("the raw stream connection does not implement halfCloser")
 	}
 
-	stdin2conn := make(chan error)
-	conn2stdout := make(chan error)
+	stdin2conn := make(chan error, 1)
+	conn2stdout := make(chan error, 1)
 	go func() {
 		stdin2conn <- copier(connHalfCloser, &halfReadCloserWrapper{os.Stdin}, "stdin to stream")
 	}()