Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

un-fork github.com/spf13/pflag #1330

Open
thaJeztah opened this issue Aug 31, 2018 · 1 comment
Open

un-fork github.com/spf13/pflag #1330

thaJeztah opened this issue Aug 31, 2018 · 1 comment
Labels
kind/refactor PR's that refactor, or clean-up code

Comments

@thaJeztah
Copy link
Member

Pull request #1233 switch the pflag package to a temporary fork, waiting for spf13/pflag#170 to be merged upstream #1233 (comment)

cli/vendor.conf

Lines 75 to 76 in c67e057

# temporary fork with https://github.com/spf13/pflag/pull/170 applied, which isn't merged yet upstream
github.com/spf13/pflag 4cb166e4f25ac4e8016a3595bbf7ea2e9aa85a2c https://github.com/thaJeztah/pflag.git

We should try to get spf13/pflag#170 reviewed and merged upstream, so that we can get rid of the fork

/cc @selansen

@thaJeztah
Copy link
Member Author

Fork was removed in #2487, but by copying the IPNetSliceValue locally; ideally we would remove that once spf13/pflag does a new release with spf13/pflag#170 to be included

@thaJeztah thaJeztah added the kind/refactor PR's that refactor, or clean-up code label Jun 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/refactor PR's that refactor, or clean-up code
Projects
None yet
Development

No branches or pull requests

1 participant