Implement IPNetSliceValue locally, and un-fork spf13/pflag #2487
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
thaJeztah
force-pushed
the
unfork_spf13flags
branch
from
b6c39a1 to
d854cec
Compare
This flag type was not yet merged upstream, so instead of using a fork of spf13/pflag, define the type locally, so that we can vendor the upstream package again. Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
thaJeztah
force-pushed
the
unfork_spf13flags
branch
from
d854cec to
d07f44f
Compare
|
rebased (conflict in vendor.conf because #2490 was merged) @silvin-lubecki PTAL |
silvin-lubecki
approved these changes
May 4, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This flag type was not yet merged upstream (spf13/pflag#170), so instead of using a fork of spf13/pflag, define the type locally, so that we can vendor the upstream package again.
Addresses #1330