Commits on May 11, 2018

1. Fix service rollback options being cross-wired …

   The "update" and "rollback" configurations were cross-wired, as a result, setting
   `--rollback-*` options would override the service's update-options.
   
   Creating a service with both update, and rollback configuration:
   
       docker service create \
         --name=test \
         --update-failure-action=pause \
         --update-max-failure-ratio=0.6 \
         --update-monitor=3s \
         --update-order=stop-first \
         --update-parallelism=3 \
         --rollback-failure-action=continue \
         --rollback-max-failure-ratio=0.5 \
         --rollback-monitor=4s \
         --rollback-order=start-first \
         --rollback-parallelism=2 \
         --tty \
         busybox
   
   Before this change:
   
       docker service inspect --format '{{json .Spec.UpdateConfig}}' test \
       && docker service inspect --format '{{json .Spec.RollbackConfig}}' test
   
   Produces:
   
       {"Parallelism":3,"FailureAction":"pause","Monitor":3000000000,"MaxFailureRatio":0.6,"Order":"stop-first"}
       {"Parallelism":3,"FailureAction":"pause","Monitor":3000000000,"MaxFailureRatio":0.6,"Order":"stop-first"}
   
   After this change:
   
       {"Parallelism":3,"FailureAction":"pause","Monitor":3000000000,"MaxFailureRatio":0.6,"Order":"stop-first"}
       {"Parallelism":2,"FailureAction":"continue","Monitor":4000000000,"MaxFailureRatio":0.5,"Order":"start-first"}
   
   Signed-off-by: Sebastiaan van Stijn <github@gone.nl>

   

   thaJeztah committed May 11, 2018
   Configuration menu

   • View commit details
   • Copy full SHA for f367aa9
   • Browse repository at this point

   Copy the full SHA

   f367aa9 View commit details

   Browse the repository at this point in the history