Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[enhancement] enable buildkit from daemon side #1275

Merged
merged 2 commits into from
Aug 20, 2018

Conversation

AntaresS
Copy link
Contributor

@AntaresS AntaresS commented Aug 6, 2018

This PR needs to have latest of github.com/docker/docker vendored into the docker/cli codebase to make use of the feature flags.

- What I did

- How I did it

- How to verify it
Now with "experimental" and "buildkit" enabled on the daemon side, docker build will use buildkit as builder

- Description for the changelog

- A picture of a cute animal (not mandatory but encouraged)

@AntaresS
Copy link
Contributor Author

AntaresS commented Aug 6, 2018

waiting on moby/moby#37593
Will update vendor.conf after the moby PR merged.

@AntaresS
Copy link
Contributor Author

AntaresS commented Aug 7, 2018

@andrewhsu @tonistiigi @tiborvass ptal

@codecov-io
Copy link

codecov-io commented Aug 20, 2018

Codecov Report

Merging #1275 into master will decrease coverage by <.01%.
The diff coverage is 50%.

@@            Coverage Diff             @@
##           master    #1275      +/-   ##
==========================================
- Coverage   54.77%   54.77%   -0.01%     
==========================================
  Files         292      292              
  Lines       19257    19260       +3     
==========================================
+ Hits        10548    10549       +1     
- Misses       8055     8056       +1     
- Partials      654      655       +1

@AntaresS AntaresS changed the title [wip] enable buildkit from daemon side instead of set env var on client host [enhancement] enable buildkit from daemon side instead of set env var on client host Aug 20, 2018
@andrewhsu
Copy link
Contributor

Talked with @AntaresS about this PR, needs update of vendor of github.com/docker/docker

Signed-off-by: Anda Xu <anda.xu@docker.com>
@AntaresS AntaresS force-pushed the buildkit-support branch 2 times, most recently from ba8ab81 to f00c470 Compare August 20, 2018 19:04
@AntaresS
Copy link
Contributor Author

@andrewhsu dependency conflicts resolved.

@AntaresS AntaresS changed the title [enhancement] enable buildkit from daemon side instead of set env var on client host [enhancement] enable buildkit from daemon side Aug 20, 2018
Copy link
Collaborator

@tiborvass tiborvass left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@tiborvass tiborvass left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

vendoring is weird here, let's investigate

@AntaresS AntaresS force-pushed the buildkit-support branch 2 times, most recently from ff1f8c8 to 8d94444 Compare August 20, 2018 22:31
Signed-off-by: Anda Xu <anda.xu@docker.com>
Copy link
Collaborator

@tiborvass tiborvass left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@andrewhsu andrewhsu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@andrewhsu andrewhsu merged commit 2461cd6 into docker:master Aug 20, 2018
@GordonTheTurtle GordonTheTurtle added this to the 18.09.0 milestone Aug 20, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants