-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[enhancement] enable buildkit from daemon side #1275
Conversation
waiting on moby/moby#37593 |
cab7cec
to
01b214c
Compare
Codecov Report
@@ Coverage Diff @@
## master #1275 +/- ##
==========================================
- Coverage 54.77% 54.77% -0.01%
==========================================
Files 292 292
Lines 19257 19260 +3
==========================================
+ Hits 10548 10549 +1
- Misses 8055 8056 +1
- Partials 654 655 +1 |
Talked with @AntaresS about this PR, needs update of vendor of |
01b214c
to
5d613dc
Compare
Signed-off-by: Anda Xu <anda.xu@docker.com>
ba8ab81
to
f00c470
Compare
@andrewhsu dependency conflicts resolved. |
f00c470
to
5783b38
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
vendoring is weird here, let's investigate
ff1f8c8
to
8d94444
Compare
Signed-off-by: Anda Xu <anda.xu@docker.com>
8d94444
to
acf43b6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This PR needs to have latest of
github.com/docker/docker
vendored into thedocker/cli
codebase to make use of the feature flags.- What I did
--buildkit
option to enable buildkit in daemon [enhancement] add optional (features) fields in daemon.json to enable buildkit moby/moby#37593.DOCKER_BUILDKIT
env var setup from client host.- How I did it
- How to verify it
Now with "experimental" and "buildkit" enabled on the daemon side,
docker build
will use buildkit as builder- Description for the changelog
- A picture of a cute animal (not mandatory but encouraged)