build: add options to builder prune #1327
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tiborvass
force-pushed
the
cmd-builder-prune-with-options
branch
3 times, most recently
from
d2c48d1
to
8d4de02
Compare
Codecov Report
@@ Coverage Diff @@
## master #1327 +/- ##
==========================================
- Coverage 54.82% 54.64% -0.19%
==========================================
Files 292 293 +1
Lines 19267 19360 +93
==========================================
+ Hits 10564 10580 +16
- Misses 8044 8119 +75
- Partials 659 661 +2 |
tiborvass
force-pushed
the
cmd-builder-prune-with-options
branch
7 times, most recently
from
e89e1c3
to
82ee8e1
Compare
tiborvass
changed the title
tiborvass
force-pushed
the
cmd-builder-prune-with-options
branch
from
82ee8e1
to
cd5550b
Compare
tonistiigi
reviewed
Sep 4, 2018
cli/command/formatter/buildcache.go
Outdated
| sort.Slice(buildCache, func(i, j int) bool { | ||
| lui, luj := buildCache[i].LastUsedAt, buildCache[j].LastUsedAt | ||
| switch { | ||
| case lui == luj: |
There was a problem hiding this comment.
explicit nil check is more readable
cli/command/formatter/buildcache.go
Outdated
| case lui.Equal(*luj): | ||
| return strings.Compare(buildCache[i].ID, buildCache[j].ID) < 0 | ||
| } | ||
| return lui.Before(*luj) |
cli/command/formatter/disk_usage.go
Outdated
| for _, v := range ctx.BuildCache { | ||
| t.Execute(ctx.Output, *v) | ||
| if !v.Shared { |
There was a problem hiding this comment.
Shouldn't filter in here, but in the summary bytes.
This patch adds --filter, --keep-storage, --all and --force to builder prune. Signed-off-by: Tibor Vass <tibor@docker.com>
tiborvass
force-pushed
the
cmd-builder-prune-with-options
branch
7 times, most recently
from
3c46602
to
b774911
Compare
Signed-off-by: Tibor Vass <tibor@docker.com>
tiborvass
force-pushed
the
cmd-builder-prune-with-options
branch
from
b774911
to
ca608c2
Compare
1 task
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Tibor Vass tibor@docker.com
Related to moby/moby#37651
This patch fixes the UX around build cache:
--filter,--keep-storage,--all,--force. This is needed to to avoid situations where user needs to prune all their cache, and they can thus prune only a subset of their cache.system dfconsistent with the way other types are shown (containers, images, volumes...)