Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[18.09 backport] builder documentation updates #1531

Merged
merged 2 commits into from
Nov 21, 2018

Conversation

thaJeztah
Copy link
Member

backports of documentation changes from;

cherry-picks were clean; no conflicts

sudo-bmitch and others added 2 commits November 21, 2018 17:16
Signed-off-by: Brandon Mitchell <git@bmitch.net>
(cherry picked from commit cc316fd)
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com>
Signed-off-by: Tibor Vass <tibor@docker.com>
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
(cherry picked from commit 83aeb21)
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Copy link
Collaborator

@vdemeester vdemeester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🐯

Copy link
Member Author

@thaJeztah thaJeztah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

author LGTM; let's merge

@thaJeztah thaJeztah merged commit 1274f23 into docker:18.09 Nov 21, 2018
@thaJeztah thaJeztah deleted the 18.09_backport_builder_docs branch November 21, 2018 17:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants