Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[18.09 backport] Add bash completion for import --platform #1554

Merged

Conversation

thaJeztah
Copy link
Member

backport of #1546 for 18.09

relates to #1371 / #1375

cherry-pick was clean; no conflicts

Signed-off-by: Harald Albers <github@albersweb.de>
(cherry picked from commit e0fe546)
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
@thaJeztah
Copy link
Member Author

@albers @vdemeester

@codecov-io
Copy link

Codecov Report

Merging #1554 into 18.09 will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##            18.09    #1554   +/-   ##
=======================================
  Coverage   54.07%   54.07%           
=======================================
  Files         290      290           
  Lines       19402    19402           
=======================================
  Hits        10492    10492           
  Misses       8237     8237           
  Partials      673      673

1 similar comment
@codecov-io
Copy link

Codecov Report

Merging #1554 into 18.09 will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##            18.09    #1554   +/-   ##
=======================================
  Coverage   54.07%   54.07%           
=======================================
  Files         290      290           
  Lines       19402    19402           
=======================================
  Hits        10492    10492           
  Misses       8237     8237           
  Partials      673      673

Copy link
Collaborator

@albers albers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks.

Copy link
Collaborator

@cpuguy83 cpuguy83 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cpuguy83 cpuguy83 merged commit 2aa77af into docker:18.09 Dec 7, 2018
@thaJeztah thaJeztah deleted the 18.09_backport_completion-import--platform branch December 7, 2018 21:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants