Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a fmt build target and make use of a go build cache. #1558

Merged
merged 2 commits into from
Dec 17, 2018
Merged

Add a fmt build target and make use of a go build cache. #1558

merged 2 commits into from
Dec 17, 2018

Commits on Dec 10, 2018

  1. build: Add a fmt target which runs gofmt on all files. 

    Signed-off-by: Ian Campbell <ijc@docker.com>
    Ian Campbell committed Dec 10, 2018
    Configuration menu
    Copy the full SHA
    7c8ee78 View commit details
    Browse the repository at this point in the history

Commits on Dec 11, 2018

  1. Use a go build cache to speed up builds. 

    With a docker build cache already primed with the build image I am seeing
`time make build -f docker.Makefile DOCKER_BUILDKIT=1 GO_BUILD_CACHE=n` takes
more than 1 minute.

By contrast `time make build -f docker.Makefile DOCKER_BUILDKIT=1
GO_BUILD_CACHE=y` takes less than 10s with a hot cache irrespective of whether
the source tree has changed

Signed-off-by: Ian Campbell <ijc@docker.com>
    Ian Campbell committed Dec 11, 2018
    Configuration menu
    Copy the full SHA
    d5de835 View commit details
    Browse the repository at this point in the history