Bump Golang 1.12.1 #1708
Merged
Bump Golang 1.12.1 #1708
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ah, caught some failures; |
|
Ahm.. more to fix; https://jenkins.dockerproject.org/job/docker/job/cli/job/PR-1708/2/execution/node/27/log/?consoleFull |
Codecov Report
@@ Coverage Diff @@
## master #1708 +/- ##
=======================================
Coverage 56.23% 56.23%
=======================================
Files 307 307
Lines 21125 21125
=======================================
Hits 11880 11880
Misses 8382 8382
Partials 863 863 |
|
created separate PR's for the fixes;
|
thaJeztah
force-pushed
the
bump_golang_1.12
branch
2 times, most recently
from
994dd74
to
9c85462
Compare
|
rebased this on top of #1742, so that we can merge that one first (and cherry-pick into the 18.09 release branch) |
thaJeztah
added
status/2-code-review
impact/changelog
and removed
status/0-triage
labels
go1.12.1 (released 2019/03/14) includes fixes to cgo, the compiler, the go command, and the fmt, net/smtp, os, path/filepath, sync, and text/template packages. See the Go 1.12.1 milestone on our issue tracker for details. For the relase notes of Go 1.12.0, see: https://golang.org/doc/go1.12 Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
thaJeztah
force-pushed
the
bump_golang_1.12
branch
from
9c85462
to
81b319a
Compare
|
rebased; this should be ready to go now 👍 |
tiborvass
approved these changes
Mar 19, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Counterpart for the engine is in moby/moby#38404
Making this "WIP" for now, as there's a known regression in Go 1.12.0 that's affecting the engine, so let's wait for 1.12.1 moby/moby#38404 (comment)