-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add systctl support for services #1754
Conversation
ping @dperny @silvin-lubecki @vdemeester ptal |
6327aa3
to
bb72d64
Compare
Codecov Report
@@ Coverage Diff @@
## master #1754 +/- ##
==========================================
+ Coverage 56.27% 56.32% +0.05%
==========================================
Files 307 307
Lines 21151 21163 +12
==========================================
+ Hits 11902 11920 +18
+ Misses 8382 8378 -4
+ Partials 867 865 -2 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Completion LGTM. Flag annotation looks odd.
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
bb72d64
to
f620349
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🐯
cli changes for moby/moby#37701