Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix annnotation on docker config create --template-driver #1769

Merged
merged 1 commit into from
Mar 21, 2019

Conversation

simonferquel
Copy link
Contributor

- What I did
Fixed an annotation that was set on an incorrect flag
- How I did it
Spotted it while working on deferred client initialization

cc @thaJeztah

Signed-off-by: Simon Ferquel <simon.ferquel@docker.com>
Copy link
Member

@thaJeztah thaJeztah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@codecov-io
Copy link

Codecov Report

Merging #1769 into master will not change coverage.
The diff coverage is 100%.

@@           Coverage Diff           @@
##           master    #1769   +/-   ##
=======================================
  Coverage   56.32%   56.32%           
=======================================
  Files         307      307           
  Lines       21177    21177           
=======================================
  Hits        11928    11928           
  Misses       8382     8382           
  Partials      867      867

1 similar comment
@codecov-io
Copy link

Codecov Report

Merging #1769 into master will not change coverage.
The diff coverage is 100%.

@@           Coverage Diff           @@
##           master    #1769   +/-   ##
=======================================
  Coverage   56.32%   56.32%           
=======================================
  Files         307      307           
  Lines       21177    21177           
=======================================
  Hits        11928    11928           
  Misses       8382     8382           
  Partials      867      867

@thaJeztah
Copy link
Member

introduced in #896 (part of 18.03)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants