Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[18.09 backport] Fix the stack informer's selector used to track deployment #1794

Merged

Conversation

thaJeztah
Copy link
Member

@thaJeztah thaJeztah commented Apr 1, 2019

backport of #1784 for 18.09

Old selector was wrong (it watched for the label we applied to child
resources when reconciling the stack, instead of the stack itself)

This should be back-ported to older version of the CLI

Old selector was wrong (it watched for the label we applied to child
resources when reconciling the stack, instead of the stack itself)

This should be back-ported to older version of the CLI

Signed-off-by: Simon Ferquel <simon.ferquel@docker.com>
(cherry picked from commit 8cd74eb)
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
@thaJeztah
Copy link
Member Author

ping @simonferquel @silvin-lubecki PTAL

@codecov-io
Copy link

Codecov Report

Merging #1794 into 18.09 will increase coverage by 0.01%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##            18.09    #1794      +/-   ##
==========================================
+ Coverage   54.22%   54.23%   +0.01%     
==========================================
  Files         290      290              
  Lines       19428    19428              
==========================================
+ Hits        10535    10537       +2     
+ Misses       8214     8212       -2     
  Partials      679      679

1 similar comment
@codecov-io
Copy link

Codecov Report

Merging #1794 into 18.09 will increase coverage by 0.01%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##            18.09    #1794      +/-   ##
==========================================
+ Coverage   54.22%   54.23%   +0.01%     
==========================================
  Files         290      290              
  Lines       19428    19428              
==========================================
+ Hits        10535    10537       +2     
+ Misses       8214     8212       -2     
  Partials      679      679

Copy link
Collaborator

@vdemeester vdemeester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🐯

Copy link
Contributor

@silvin-lubecki silvin-lubecki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@silvin-lubecki silvin-lubecki merged commit c805ad2 into docker:18.09 Apr 2, 2019
@thaJeztah thaJeztah deleted the 18.09_backport_fix_stack_watch branch April 2, 2019 11:25
@thaJeztah thaJeztah modified the milestones: 18.09.6, 18.09.5 Apr 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants