bump google.golang.org/grpc v1.20.1 #1824
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1824 +/- ##
=======================================
Coverage 56.74% 56.74%
=======================================
Files 309 309
Lines 21676 21676
=======================================
Hits 12301 12301
Misses 8476 8476
Partials 899 899 |
thaJeztah
force-pushed
the
bump_grpc_1.20.0
branch
from
e36d10c
to
b60ce1a
Compare
|
whoops, forgot #1811 wasn't merged yet; rebased on top of that |
|
this may potentially break buildkit? moby/buildkit#936 |
|
Yes, let's make this WIP for now (until we figure out what's happening there) |
thaJeztah
changed the title
thaJeztah
changed the title
full diff: grpc/grpc-go@v1.12.2...v1.20.1 includes grpc/grpc-go#2695 transport: do not close channel that can lead to panic addresses moby/moby#39053 Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
thaJeztah
force-pushed
the
bump_grpc_1.20.0
branch
from
b60ce1a
to
93d76c5
Compare
thaJeztah
changed the title
thaJeztah
changed the title
tonistiigi
approved these changes
May 14, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
full diff: grpc/grpc-go@v1.12.2...v1.20.1
includes grpc/grpc-go#2695 transport: do not close channel that can lead to panic
fixes moby/moby#39053
depends on moby/buildkit#936