Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[19.03 backport] backport BuildKit fixes #1879

Merged
merged 3 commits into from
May 13, 2019
Merged

[19.03 backport] backport BuildKit fixes #1879

merged 3 commits into from
May 13, 2019

Conversation

thaJeztah
Copy link
Member

Tibor Vass added 3 commits May 13, 2019 09:13
@thaJeztah
build: honor BUILDKIT_PROGRESS env config
529b1e7 
Signed-off-by: Tibor Vass <tibor@docker.com>
(cherry picked from commit 8adcedd)
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
@thaJeztah
build: add --platform local
8758cdc 
Signed-off-by: Tibor Vass <tibor@docker.com>
(cherry picked from commit daca70d)
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
@thaJeztah
vendor buildkit to 646fc0af6d283397b9e47cd0a18779e9d0376e0e (v0.5.1)
3f9063e 
Signed-off-by: Tibor Vass <tibor@docker.com>
(cherry picked from commit 7f45a0e)
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
@thaJeztah thaJeztah added this to the 19.03.0 milestone May 13, 2019
@thaJeztah
Copy link
Member Author

ping @tiborvass @tonistiigi PTAL

silvin-lubecki
silvin-lubecki approved these changes May 13, 2019
View reviewed changes
Copy link
Contributor

@silvin-lubecki silvin-lubecki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov-io
Copy link

Codecov Report

Merging #1879 into 19.03 will decrease coverage by 0.01%.
The diff coverage is 0%.

@@            Coverage Diff             @@
##            19.03    #1879      +/-   ##
==========================================
- Coverage   56.75%   56.74%   -0.02%     
==========================================
  Files         309      309              
  Lines       21658    21662       +4     
==========================================
  Hits        12292    12292              
- Misses       8469     8473       +4     
  Partials      897      897

@thaJeztah thaJeztah merged commit 12a1cf4 into docker:19.03 May 13, 2019
@thaJeztah thaJeztah deleted the 19.03_backport_buildkit_fixes branch May 14, 2019 01:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tonistiigi tonistiigi tonistiigi approved these changes

@silvin-lubecki silvin-lubecki silvin-lubecki approved these changes

Assignees
No one assigned
Labels
area/builder status/2-code-review
Projects
None yet
Milestone
19.03.0
Development

Successfully merging this pull request may close these issues.
5 participants
@thaJeztah @codecov-io @tonistiigi @silvin-lubecki @GordonTheTurtle