Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TestHistoryContext_CreatedSince: skip on non-UTC environments #2427

Merged
merged 1 commit into from
Apr 9, 2020
Merged

TestHistoryContext_CreatedSince: skip on non-UTC environments #2427

merged 1 commit into from
Apr 9, 2020

Conversation

thaJeztah
Copy link
Member

This test failed when running on the host on my Mac, due to the date/time format being different

@thaJeztah
TestHistoryContext_CreatedSince: skip on non-UTC environments
650c717 
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
@thaJeztah
Copy link
Member Author

@silvin-lubecki PTAL

silvin-lubecki
silvin-lubecki approved these changes Apr 9, 2020
View reviewed changes
Copy link
Contributor

@silvin-lubecki silvin-lubecki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@silvin-lubecki silvin-lubecki merged commit 5d6281b into docker:master Apr 9, 2020
@thaJeztah thaJeztah deleted the skip_TestHistoryContext_CreatedSince branch April 9, 2020 16:05
@thaJeztah thaJeztah added this to the 20.03.0 milestone Apr 10, 2020
@imjasonh imjasonh mentioned this pull request Sep 16, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@silvin-lubecki silvin-lubecki silvin-lubecki approved these changes

Assignees
No one assigned
Labels
area/testing status/2-code-review
Projects
None yet
Milestone
20.10.0
Development

Successfully merging this pull request may close these issues.
2 participants
@thaJeztah @silvin-lubecki