Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[19.03 backport] vendor: golang.org/x/crypto 2aa609cf4a9d7d1126360de73b55b6002f9e052a #2623

Merged
merged 1 commit into from
Jul 9, 2020
Merged

[19.03 backport] vendor: golang.org/x/crypto 2aa609cf4a9d7d1126360de73b55b6002f9e052a #2623

merged 1 commit into from
Jul 9, 2020

Conversation

s0j
Copy link

@s0j s0j commented Jul 9, 2020

vendor: golang.org/x/crypto 2aa609cf4a9d7d1126360de73b55b6002f9e052a

full diff: golang/crypto@69ecbb4...2aa609c

The cherry-pick didn't apply cleanly, so I took the single 'golang.org/x/crypto'
change in vendor.conf and re-ran vndr.

The motivation behind this is to address the input regression on Windows caused by:
golang/crypto@6d4e4cb

.. and addressed in:
golang/crypto@ecb85df

(cherry picked from commit 37d184f)
Signed-off-by: Shane Jarych sjarych@mirantis.com

full diff: golang/crypto@69ecbb4...2aa609c

The cherry-pick didn't apply cleanly, so I took the single 'golang.org/x/crypto'
change in vendor.conf and re-ran vndr.

The motivation behind this is to address the input regression on Windows caused by:
golang/crypto@6d4e4cb

.. and addressed in:
golang/crypto@ecb85df

(cherry picked from commit 37d184f)
Signed-off-by: Shane Jarych <sjarych@mirantis.com>
@thaJeztah thaJeztah added this to the 19.03.13 milestone Jul 9, 2020
@thaJeztah
Copy link
Member

Is this still draft?

@s0j s0j marked this pull request as ready for review July 9, 2020 16:22
@s0j
Copy link
Author

s0j commented Jul 9, 2020

Is this still draft?

No longer draft -- thanks!

Copy link
Member

@thaJeztah thaJeztah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@cpuguy83 cpuguy83 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cpuguy83 cpuguy83 merged commit b0a78cc into docker:19.03 Jul 9, 2020
@s0j s0j deleted the s0j_19.03_bump-crypto-readconsole branch July 9, 2020 19:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants