Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add bash completion for jobs #2887

Merged
merged 1 commit into from
Jan 5, 2021
Merged

Conversation

albers
Copy link
Collaborator

@albers albers commented Dec 15, 2020

ref: #2262

This adds bash completion for

  • docker service create --mode global-job|replicated-job
  • docker service create|update --max-replicas
  • docker service ls --filter mode=global-job|replicated-job

The filter for service ls currently does not work (jobs will be ignored). This will be fixed by moby/moby#41806
edit: moby/moby#41806 was merged.

Signed-off-by: Harald Albers <github@albersweb.de>
Copy link
Member

@thaJeztah thaJeztah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

Copy link
Contributor

@silvin-lubecki silvin-lubecki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants