Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

changed the container name in docker stats page #4027

Closed
wants to merge 3 commits into from

Conversation

aslamahemad
Copy link
Contributor

@aslamahemad aslamahemad commented Feb 14, 2023

- What I did

  • I changed the container name from drunk_visvesraya to humble_visvesraya. It "fixes #16720"

- How I did it

  • $ sed -i 's/drunk/humble/g' stats.md

- How to verify it

  • $ cat ~/cli/docs/reference/commandline/stats.md | grep "humble"

- Description for the changelog

- A picture of a cute animal (not mandatory but encouraged)

crazy-max and others added 3 commits February 14, 2023 15:32
Signed-off-by: CrazyMax <crazy-max@users.noreply.github.com>
Signed-off-by: Aslam Ahemad <aslamahemad@gmail.com>
Signed-off-by: Aslam Ahemad <aslamahemad@gmail.com>
Copy link
Member

@thaJeztah thaJeztah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changing the name LGTM (thanks!)

looks like the PR may need a squash and a tiny fix-up for the column. Let me try fix that and push to this PR

drunk_visvesvaraya 0.00% 0B / 0B
humble_visvesvaraya 0.00% 0B / 0B
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should probably fix the column aligning now (as the new name is 1 character wider)

@thaJeztah
Copy link
Member

didn't want to force-push to a master branch, so I'm carrying this in #4031

@thaJeztah
Copy link
Member

Thanks @aslamahemad ! Your changes were merged as part of #4031 (they still need to be backported and updated in the docs, so won't be "live" yet on docs.docker.com)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants