Print timestamp when --human=true #438
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Setting "--human=true" changes "CreatedSince" format * "CreatedAt" now displays the creation timestamp as specified in the documents Signed-off-by: Boaz Shuster <ripcurld.github@gmail.com>
Codecov Report
@@ Coverage Diff @@
## master #438 +/- ##
=========================================
+ Coverage 46.28% 46.3% +0.02%
=========================================
Files 194 194
Lines 16134 16137 +3
=========================================
+ Hits 7467 7472 +5
+ Misses 8278 8276 -2
Partials 389 389 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR closes #437
- What I did
--human=truechangesCreatedSinceformatCreatedAtnow displays the creation timestamp as specified in the documents- How I did it
historyContext.CreatedSinceandhistoryContext.CreatedAtincli/command/formatter/history.gocli/command/formatter/history_test.go- How to verify it
Run unit tests
- Description for the changelog
- A picture of a cute animal (not mandatory but encouraged)