Show images digests when "{{.Digest}}" is in format #439
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Have no idea why test keeps failing. 🤔🐺❓ |
|
It's failing to upload code coverage to codedov service. It might be down. It's not related to your change. |
This patch fixes the following bug: Running "docker image ls --digests" will add images digests to the image table. However, when using "format" to display images digests all of them are "<none>". Signed-off-by: Boaz Shuster <ripcurld.github@gmail.com>
Codecov Report
@@ Coverage Diff @@
## master #439 +/- ##
==========================================
- Coverage 47.01% 46.28% -0.74%
==========================================
Files 198 194 -4
Lines 16334 16136 -198
==========================================
- Hits 7680 7468 -212
- Misses 8260 8279 +19
+ Partials 394 389 -5 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
- What I did
This patch fixes the following bug #435:
Running "docker image ls --digests" will add images digests
to the image table. However, when using "format" to display
images digests all of them are "".
- How I did it
In
cli/command/formatter/image.goif either--digestsistrueor{{.Digest}}is in--formatthen display the image digest. Otherwise, set it tonil.- How to verify it
Run unit-tests
- Description for the changelog
Fix #435
- A picture of a cute animal (not mandatory but encouraged)