-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for configs #45
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aaronlehmann
force-pushed
the
configs
branch
3 times, most recently
from
May 10, 2017 21:30
2f788b2
to
0e2b9d3
Compare
vdemeester
approved these changes
May 11, 2017
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code LGTM 😉
Signed-off-by: Aaron Lehmann <aaron.lehmann@docker.com>
Signed-off-by: Aaron Lehmann <aaron.lehmann@docker.com>
Rebased. Please merge to unblock other moby PRs that involve CLI (this fork is currently referenced). |
mlaventure
approved these changes
May 11, 2017
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
albers
added a commit
to albers/docker-cli
that referenced
this pull request
Jul 3, 2017
This adds bash completion for - docker#45 - moby/moby#32336 Signed-off-by: Harald Albers <github@albersweb.de>
albers
added a commit
to albers/docker-cli
that referenced
this pull request
Jul 7, 2017
This adds bash completion for - docker#45 - moby/moby#32336 Signed-off-by: Harald Albers <github@albersweb.de>
thaJeztah
pushed a commit
to thaJeztah/docker-ce
that referenced
this pull request
Jul 25, 2017
This adds bash completion for - docker/cli#45 - moby/moby#32336 Signed-off-by: Harald Albers <github@albersweb.de> (cherry picked from commit c40952b3058db3c6e44bca8c518d888b83878ce5) Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
alshabib
pushed a commit
to alshabib/cli
that referenced
this pull request
Aug 1, 2017
This adds bash completion for - docker#45 - moby/moby#32336 Signed-off-by: Harald Albers <github@albersweb.de>
riyazdf
pushed a commit
to riyazdf/cli
that referenced
this pull request
Aug 2, 2017
This adds bash completion for - docker#45 - moby/moby#32336 Signed-off-by: Harald Albers <github@albersweb.de>
silvin-lubecki
pushed a commit
to silvin-lubecki/docker-ce
that referenced
this pull request
Jan 29, 2020
This adds bash completion for - docker/cli#45 - moby/moby#32336 Signed-off-by: Harald Albers <github@albersweb.de> (cherry picked from commit c40952b3058db3c6e44bca8c518d888b83878ce5) Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
silvin-lubecki
pushed a commit
to silvin-lubecki/cli-extract
that referenced
this pull request
Jan 30, 2020
This adds bash completion for - docker/cli#45 - moby/moby#32336 Signed-off-by: Harald Albers <github@albersweb.de> (cherry picked from commit c40952b) Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds CLI support for the configs feature (moby/moby#32336).
It should not be merged until the moby PR is merged.