Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[26.1 Backport] docs: clarify that --data-path-addr doesn't restrict access #5068

Merged
merged 1 commit into from
May 13, 2024
Merged

[26.1 Backport] docs: clarify that --data-path-addr doesn't restrict access #5068

merged 1 commit into from
May 13, 2024

Conversation

dvdksn
Copy link
Contributor

@dvdksn dvdksn commented May 13, 2024 •
edited

@dvdksn
docs: clarify that --data-path-addr doesn't restrict access
81b482e 
Signed-off-by: David Karlsson <35727626+dvdksn@users.noreply.github.com>
(cherry picked from commit faf096b)
Signed-off-by: David Karlsson <35727626+dvdksn@users.noreply.github.com>
@dvdksn dvdksn requested a review from thaJeztah as a code owner May 13, 2024 17:01
@dvdksn dvdksn changed the title docs: clarify that --data-path-addr doesn't restrict access [26.1 Backport] docs: clarify that --data-path-addr doesn't restrict access May 13, 2024
@thaJeztah thaJeztah added this to the 26.1.3 milestone May 13, 2024
thaJeztah
thaJeztah approved these changes May 13, 2024
View reviewed changes
Copy link
Member

@thaJeztah thaJeztah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 61.09%. Comparing base (211e74b) to head (81b482e).

Additional details and impacted files 
@@            Coverage Diff             @@
##             26.1    #5068      +/-   ##
==========================================
- Coverage   61.10%   61.09%   -0.01%     
==========================================
  Files         298      295       -3     
  Lines       20671    20666       -5     
==========================================
- Hits        12631    12626       -5     
+ Misses       7143     7142       -1     
- Partials      897      898       +1

@thaJeztah thaJeztah merged commit 60f2d38 into docker:26.1 May 13, 2024
103 of 104 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@neersighted neersighted neersighted approved these changes

@thaJeztah thaJeztah thaJeztah approved these changes

Assignees
No one assigned
Labels
area/swarm kind/docs status/3-docs-review
Projects
None yet
Milestone
26.1.3
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@dvdksn @codecov-commenter @neersighted @thaJeztah