-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cli: make initializing the global meter- and tracing providers optional #5188
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #5188 +/- ##
==========================================
- Coverage 61.74% 61.42% -0.32%
==========================================
Files 297 298 +1
Lines 20787 20797 +10
==========================================
- Hits 12835 12775 -60
- Misses 7037 7109 +72
+ Partials 915 913 -2 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tiny nit but LGTM
@@ -92,6 +92,8 @@ type DockerCli struct { | |||
// this may be replaced by explicitly passing a context to functions that | |||
// need it. | |||
baseCtx context.Context | |||
|
|||
enableGlobalMeter, enableGlobalTracer bool |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: we should probably call these Meter/TracerProvider
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, they were already far too long names for an un-exported field 😂
13addd4
to
947effd
Compare
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
947effd
to
617eb52
Compare
- Description for the changelog
- A picture of a cute animal (not mandatory but encouraged)