Fix markdown link in service-create reference docs #603
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Markdown nested in a HTML table doesn't work, so changing the link to a plain HTML link. Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
mdlinville
approved these changes
Oct 5, 2017
| @@ -294,8 +294,9 @@ volumes in a service: | |||
| <td> | |||
| <p>The type of mount, can be either <tt>volume</tt>, <tt>bind</tt>, or <tt>tmpfs</tt>. Defaults to <tt>volume</tt> if no type is specified. | |||
| <ul> | |||
| <li><tt>volume</tt>: mounts a [managed volume](volume_create.md) into the container.</li> | |||
| <li><tt>bind</tt>: bind-mounts a directory or file from the host into the container.</li> | |||
| <li><tt>volume</tt>: mounts a <a href="https://docs.docker.com/engine/reference/commandline/volume_create/">managed volume</a> | |||
There was a problem hiding this comment.
This is an OK fix. Alternatively, you could add markdown="span" as an attribute to the <li> and leave the Markdown in there. Your choice. I think you could also avoid the <tt> tags too, in favor of backticks.
There was a problem hiding this comment.
Oh, didn't know about that one! I think I'll keep it like this for now (mixing HTML and Markdown in a table may be confusing), but we could change it in a single go if we think it's better
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Markdown nested in a HTML table doesn't work, so changing the link to a plain HTML link.
fixes #602
ping @johndmulhausen @mstanleyjones