-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix behaviour of rmi -f
with unexpected errors
#654
Conversation
Signed-off-by: Arash Deshmeh <adeshmeh@ca.ibm.com>
f9e3d75
to
b900676
Compare
Signed-off-by: Daniel Nephin <dnephin@docker.com>
Codecov Report
@@ Coverage Diff @@
## master #654 +/- ##
==========================================
+ Coverage 50.02% 50.03% +0.01%
==========================================
Files 216 216
Lines 17676 17680 +4
==========================================
+ Hits 8842 8846 +4
Misses 8391 8391
Partials 443 443 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
First commit from #418 LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks for carrying!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🐮
Noticed this PR while trying to debug the following oddity (missing trailing newline):
This patch (or something related to it) fixes that but changes the exit code:
From this it seems intentional, but perhaps unfortunate: |
This PR should actually fix the problem you see in 17.09. It'll be in 17.12 |
Carry #418
Closes #418
Closes #567