Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated deprecation status for "repository:shortid" #753

Merged
merged 1 commit into from
Dec 15, 2017

Conversation

thaJeztah
Copy link
Member

Depends on moby/moby#35790

The repository:shortid syntax for referencing images is very little used,
collides with with tag references can be confused with digest references.

The repository:shortid notation was deprecated in Docker 1.13, and scheduled
for removal in Docker 17.12.

This patch updates the deprecation status for this feature.

@codecov-io
Copy link

codecov-io commented Dec 13, 2017

Codecov Report

Merging #753 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #753   +/-   ##
=======================================
  Coverage   53.45%   53.45%           
=======================================
  Files         218      218           
  Lines       14613    14613           
=======================================
  Hits         7811     7811           
  Misses       6321     6321           
  Partials      481      481

**Target For Removal In Release: v17.12**
**Removed In Release: v17.12**

The `repository:shortid` syntax for referencing images is very little used,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

references, and can

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updated, PTAL

The `repository:shortid` syntax for referencing images is very little used,
collides with with tag references can be confused with digest references.

The `repository:shortid` notation was deprecated in Docker 1.13, and scheduled
for removal in Docker 17.12.

This patch updates the deprecation status for this feature.

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Copy link
Collaborator

@vdemeester vdemeester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🦁

@thaJeztah thaJeztah changed the title [Do not merge] Updated deprecation status for "repository:shortid" Updated deprecation status for "repository:shortid" Dec 15, 2017
@thaJeztah thaJeztah merged commit 69b11da into docker:master Dec 15, 2017
@GordonTheTurtle GordonTheTurtle added this to the 18.01.0 milestone Dec 15, 2017
@thaJeztah thaJeztah deleted the image-shortid branch December 15, 2017 09:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants