Document long form of --network and --network-add #843
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sepich
requested review from
mdlinville,
thaJeztah and
vdemeester
as code owners
Codecov Report
@@ Coverage Diff @@
## master #843 +/- ##
==========================================
+ Coverage 52.67% 52.94% +0.27%
==========================================
Files 257 244 -13
Lines 16403 15839 -564
==========================================
- Hits 8640 8386 -254
+ Misses 7190 6899 -291
+ Partials 573 554 -19 |
|
Also relates to #62, which implemented the CLI side of this |
mdlinville
approved these changes
Jan 29, 2018
|
@thaJeztah @gbarr01 please work together to figure out the target version for this and figure out which narrative docs should be updated. |
thaJeztah
reviewed
Feb 15, 2018
| @@ -734,6 +734,9 @@ The swarm extends my-network to each node running the service. | |||
| Containers on the same network can access each other using | |||
| [service discovery](https://docs.docker.com/engine/swarm/networking/#use-swarm-mode-service-discovery). | |||
|
|
|||
| Long form syntax of `--network` (since v17.06) allows to specify list of aliases and driver options: | |||
There was a problem hiding this comment.
Generally we don't mention specific versions (but we should back port this change to the 17.06 and up docs archive)
thaJeztah
requested changes
Feb 15, 2018
| @@ -192,6 +192,21 @@ $ docker service update \ | |||
| myservice | |||
| ``` | |||
|
|
|||
| ### Add or remove network | |||
|
|
|||
| Use the `--network-add` or `--network-rm` flags to add or remove a network for a service. You can use the short or long syntax discussed in the | |||
There was a problem hiding this comment.
nit: can you wrap this line to 80-characters?
sepich
force-pushed
the
docs-for-pr33130
branch
from
9ef05c5
to
94ecd2b
Compare
Signed-off-by: Alexander Ryabov <i@sepa.spb.ru>
|
Sure, hopefully fixed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Alexander Ryabov i@sepa.spb.ru
- What I did
Added missing documentation for long form of --network/--network-add
- How I did it
Read PR: moby/moby/pull/33130
- How to verify it
- Description for the changelog
Document long form of --network and --network-add
- A picture of a cute animal (not mandatory but encouraged)