Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vendor docker/docker to eb36d6021618f788012c166a533f1b321cda9695 #86

Closed
wants to merge 1 commit into from
Closed

Vendor docker/docker to eb36d6021618f788012c166a533f1b321cda9695 #86

wants to merge 1 commit into from

Conversation

boaz0
Copy link
Contributor

@boaz0 boaz0 commented May 15, 2017

To compile docker/cli in Go1.8 docker/docker has to be bumped
to eb36d60.

Read more here:
golang/go#18347
moby/moby#29602
moby/moby#29030
moby/moby#32127

closes #64

To compile docker/cli in Go1.8 docker/docker has to be bumped
to eb36d60.

Read more here:
golang/go#18347
moby/moby#29602
moby/moby#29030
moby/moby#32127
@GordonTheTurtle
Copy link

Please sign your commits following these rules:
https://github.com/moby/moby/blob/master/CONTRIBUTING.md#sign-your-work
The easiest way to do this is to amend the last commit:

$ git clone -b "bump_moby" git@github.com:ripcurld0/cli.git somewhere
$ cd somewhere
$ git commit --amend -s --no-edit
$ git push -f

Amending updates the existing PR. You DO NOT need to open a new one.

@boaz0
Copy link
Contributor Author

boaz0 commented May 15, 2017

Oops, I see that it's already been done.

@boaz0 boaz0 closed this May 15, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add CheckRedirect for GO 1.8
2 participants