Carry #553 : Add option to pull images quietly #882

vdemeester · 2018-02-16T15:21:51Z

Add --quiet to the docker image pull subcommand that will pull
the image quietly.

$ docker pull -q golang:latest
$ docker pull -q golang
Using default tag: latest

Carrying #553 cc @pramodhkp

🐯

Signed-off-by: Vincent Demeester vincent@sbr.pm

codecov-io · 2018-02-16T15:27:49Z

Codecov Report

Merging #882 into master will decrease coverage by 0.01%.
The diff coverage is 57.89%.

@@            Coverage Diff             @@
##           master     #882      +/-   ##
==========================================
- Coverage   55.26%   55.25%   -0.02%     
==========================================
  Files         289      289              
  Lines       19385    19395      +10     
==========================================
+ Hits        10713    10716       +3     
- Misses       7977     7983       +6     
- Partials      695      696       +1

cpuguy83 · 2018-02-16T15:31:20Z

Do we have a good way to add a test for this?

dnephin · 2018-02-16T17:05:22Z

Yes, it should be possible to unit test this with the fake client

dnephin · 2018-02-16T17:05:32Z

Design LGTM, moving to code review based on the comments in the previous PR.

thaJeztah

changes LGTM. This also needs changes to the completion scripts; do you want to take care of those in this PR, or in a follow up?

thaJeztah · 2018-02-19T14:44:45Z

@dnephin PTAL

dnephin · 2018-02-19T20:16:15Z

It wouldn't hurt to have a unit test for the new flag since it seems our coverage is low in this area

thaJeztah · 2018-02-21T23:42:00Z

looks like a test was added

vdemeester · 2018-02-22T08:42:51Z

looks like a test was added

Well, it doesn't test anything really.. Having a bit of trouble with jsonmessage 😝 😅

thaJeztah · 2018-04-09T20:20:16Z

ping @vdemeester were you still working on a test?

vdemeester · 2018-04-10T11:53:45Z

oh dang it, forgot about that one.

vdemeester · 2018-04-11T12:36:02Z

@thaJeztah updated 😉

e2e/image/pull_test.go

vdemeester · 2018-05-17T14:56:10Z

@cpuguy83 @thaJeztah Updated, this add a new line to all docker pull like that.

thaJeztah · 2018-05-17T15:23:46Z

Output (with/without -q) now looks like:

docker pull nginx:alpine
alpine: Pulling from library/nginx
Digest: sha256:3a44395131c5a9704417d19ab4c8d6cb104013659f5babb2f1c632e789588196
Status: Image is up to date for nginx:alpine
docker.io/library/nginx:alpine

docker pull -q nginx:alpine
docker.io/library/nginx:alpine

is it a concern that we output the fully-qualified name (with docker.io...)?
would the digest be useful? i.e.; docker.io/library/nginx:alpine@sha256:3a44395131c5a9704417d19ab4c8d6cb104013659f5babb2f1c632e789588196 (or docker.io/library/nginx@sha256:3a44395131c5a9704417d19ab4c8d6cb104013659f5babb2f1c632e789588196 - without tag)?

docwhat · 2018-05-17T15:52:32Z

The :tag@sha form would be helpful. It would have everything you could want in a compact reasonably computer parseable way.

The docker.io should go away if it doesn’t match the image name. That both docker pull and docker run should be able to use the returned string.

vdemeester · 2018-05-18T09:29:50Z

The docker.io should go away if it doesn’t match the image name. That both docker pull and docker run should be able to use the returned string.

@docwhat docker run and docker pull are able to run docker.io/library/nginx:alpine (it's just that docker has some default — hub — and special cases — library).

is it a concern that we output the fully-qualified name (with docker.io...)?

I don't think it's a concern as those can be used "as is" with the docker commandline (or containerd, …)

would the digest be useful?

Good point, I guess it would be even more useful indeed

docwhat · 2018-05-18T12:12:17Z

I grok that. But if I pull nginx then I can run nginx.

If I add the namespace and host then docker run will go pull it again (though it’ll be fast since all the layers are already here).

Also docker image ls will show nginx without the namespace and host.

thaJeztah · 2018-07-10T14:45:43Z

ping @vdemeester I forgot; what's the status on this one?

jregeimbal · 2018-11-20T22:50:20Z

Bump, I've spent hours searching for a viable workaround to quiet down docker pull/push. Nothing seems to work with Semaphore CI. This would be a great feature to get in soon 👍

silvin-lubecki · 2018-11-21T10:43:16Z

Please rebase @vdemeester 🦁

Gasol · 2018-12-14T10:00:08Z

I'm on the same boat with @jregeimbal , It's very annoying to see the progress output in CI, We must press keycap page down twice or even more to ignore them over and over.

thaJeztah

whoops, missed that this was rebased; found one issue 🤗

e2e/image/pull_test.go

cli/command/image/testdata/pull-command-success.simple-quiet.golden

vdemeester · 2018-12-19T09:14:37Z

@thaJeztah updated (and rebased) 😉

thaJeztah

LGTM, thanks!!

thaJeztah · 2018-12-19T09:39:05Z

cli/command/image/trust.go

@@ -202,7 +203,12 @@ func trustedPull(ctx context.Context, cli command.Cli, imgRefAndAuth trust.Image
 		if err != nil {
 			return err
 		}
-		if err := imagePullPrivileged(ctx, cli, updatedImgRefAndAuth, false, platform); err != nil {
+		if err := imagePullPrivileged(ctx, cli, updatedImgRefAndAuth, PullOptions{
+			all:      false,


Not for this PR, but wondering if we need a validation step for --all somewhere (as it's being ignored here); i.e. is there a situation where I could've provided the --all flag, and no error is printed (but it's being ignored)

thaJeztah · 2018-12-19T09:41:59Z

oh, dang; one test needs updating;

--- FAIL: TestNewPullCommandSuccess (0.00s)
    pull_test.go:87: assertion failed: 
        --- expected
        +++ actual
        @@ -1,2 +1,3 @@
        +Using default tag: latest
         docker.io/library/image:latest

thaJeztah

see above; LGTM after the test was updated 😅 😇

Add `--quiet` to the `docker image pull` subcommand that will not pull the image quietly. ``` $ docker pull -q golang Using default tag: latest ``` Signed-off-by: Vincent Demeester <vincent@sbr.pm>

thaJeztah

LGTM, thanks for fixing!

Summary: I couldn't find any verbosity options in the [`docker pull` command docs](https://docs.docker.com/engine/reference/commandline/pull/), but `docker pull` [got a `--quiet` option](docker/cli#882) in a recent version (not sure if we're using that version), and `--quiet` for `docker push` [is forthcoming](docker/cli#1221). Pull Request resolved: #23111 Differential Revision: D16402993 Pulled By: kostmo fbshipit-source-id: 52f77b11b839d28f8cf1ecb58518ca69632d7fbe

vdemeester requested review from dnephin, cpuguy83 and thaJeztah February 16, 2018 15:21

GordonTheTurtle added the status/0-triage label Feb 16, 2018

vdemeester mentioned this pull request Feb 16, 2018

Added option for pulling quietly #553

Closed

vdemeester added status/1-design-review and removed status/0-triage labels Feb 16, 2018

dnephin added status/2-code-review and removed status/1-design-review labels Feb 16, 2018

thaJeztah added impact/changelog impact/documentation labels Feb 19, 2018

thaJeztah approved these changes Feb 19, 2018

View reviewed changes

vdemeester force-pushed the carry-553-pull-quiet-cli branch from 888701e to f836bda Compare February 20, 2018 13:44

thaJeztah mentioned this pull request Mar 22, 2018

docker push should support --quiet flag moby/moby#36655

Closed

thaJeztah mentioned this pull request Apr 10, 2018

Add a quiet option to docker pull moby/moby#13588

Closed

vdemeester force-pushed the carry-553-pull-quiet-cli branch from f836bda to 4771cbd Compare April 11, 2018 12:35

thaJeztah requested changes Apr 11, 2018

View reviewed changes

e2e/image/pull_test.go Outdated Show resolved Hide resolved

vdemeester force-pushed the carry-553-pull-quiet-cli branch from 4771cbd to de7545d Compare April 12, 2018 08:29

vdemeester removed the request for review from dnephin April 20, 2018 13:58

yoosiba mentioned this pull request Jun 14, 2018

As a Smith I want to run docker build in quiet mode eclipse-n4js/n4js#915

Closed

This was referenced Jul 16, 2018

Docker progress bar should be disabled when run without a tty moby/moby#8342

Closed

Added support for docker push --quiet #1221

Closed

vdemeester force-pushed the carry-553-pull-quiet-cli branch from 3612063 to 8f6a206 Compare November 21, 2018 13:31

thaJeztah requested changes Dec 15, 2018

View reviewed changes

e2e/image/pull_test.go Outdated Show resolved Hide resolved

cli/command/image/testdata/pull-command-success.simple-quiet.golden Show resolved Hide resolved

vdemeester force-pushed the carry-553-pull-quiet-cli branch from 8f6a206 to 56bdba7 Compare December 19, 2018 09:14

thaJeztah approved these changes Dec 19, 2018

View reviewed changes

thaJeztah requested changes Dec 19, 2018

View reviewed changes

Add option to pull images quietly

dd3407b

Add `--quiet` to the `docker image pull` subcommand that will not pull the image quietly. ``` $ docker pull -q golang Using default tag: latest ``` Signed-off-by: Vincent Demeester <vincent@sbr.pm>

vdemeester force-pushed the carry-553-pull-quiet-cli branch from 56bdba7 to dd3407b Compare December 19, 2018 12:58

thaJeztah approved these changes Dec 19, 2018

View reviewed changes

thaJeztah merged commit 6deb4f1 into docker:master Dec 19, 2018

GordonTheTurtle added this to the 19.03.0 milestone Dec 19, 2018

vdemeester deleted the carry-553-pull-quiet-cli branch December 19, 2018 13:23

albers mentioned this pull request Dec 20, 2018

Add quiet flag to bash completion for docker pull #1588

Merged

subsign mentioned this pull request Mar 23, 2019

Silence bitwarden.sh bitwarden/server#454

Closed

kostmo mentioned this pull request Jul 19, 2019

Use set -x to help investigate doc push errors pytorch/pytorch#23111

Closed

steadysupply mentioned this pull request Jan 22, 2020

Add support for docker push --quiet #2197

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Carry #553 : Add option to pull images quietly #882

Carry #553 : Add option to pull images quietly #882

vdemeester commented Feb 16, 2018 •

edited

Loading

codecov-io commented Feb 16, 2018 •

edited

Loading

cpuguy83 commented Feb 16, 2018

dnephin commented Feb 16, 2018

dnephin commented Feb 16, 2018 •

edited

Loading

thaJeztah left a comment

thaJeztah commented Feb 19, 2018

dnephin commented Feb 19, 2018

thaJeztah commented Feb 21, 2018

vdemeester commented Feb 22, 2018 •

edited

Loading

thaJeztah commented Apr 9, 2018

vdemeester commented Apr 10, 2018

vdemeester commented Apr 11, 2018

vdemeester commented May 17, 2018

thaJeztah commented May 17, 2018

docwhat commented May 17, 2018

vdemeester commented May 18, 2018 •

edited

Loading

docwhat commented May 18, 2018

thaJeztah commented Jul 10, 2018

jregeimbal commented Nov 20, 2018

silvin-lubecki commented Nov 21, 2018

Gasol commented Dec 14, 2018

thaJeztah left a comment

vdemeester commented Dec 19, 2018

thaJeztah left a comment

thaJeztah Dec 19, 2018

thaJeztah commented Dec 19, 2018

thaJeztah left a comment

thaJeztah left a comment

Carry #553 : Add option to pull images quietly #882

Carry #553 : Add option to pull images quietly #882

Conversation

vdemeester commented Feb 16, 2018 • edited Loading

codecov-io commented Feb 16, 2018 • edited Loading

Codecov Report

cpuguy83 commented Feb 16, 2018

dnephin commented Feb 16, 2018

dnephin commented Feb 16, 2018 • edited Loading

thaJeztah left a comment

Choose a reason for hiding this comment

thaJeztah commented Feb 19, 2018

dnephin commented Feb 19, 2018

thaJeztah commented Feb 21, 2018

vdemeester commented Feb 22, 2018 • edited Loading

thaJeztah commented Apr 9, 2018

vdemeester commented Apr 10, 2018

vdemeester commented Apr 11, 2018

vdemeester commented May 17, 2018

thaJeztah commented May 17, 2018

docwhat commented May 17, 2018

vdemeester commented May 18, 2018 • edited Loading

docwhat commented May 18, 2018

thaJeztah commented Jul 10, 2018

jregeimbal commented Nov 20, 2018

silvin-lubecki commented Nov 21, 2018

Gasol commented Dec 14, 2018

thaJeztah left a comment

Choose a reason for hiding this comment

vdemeester commented Dec 19, 2018

thaJeztah left a comment

Choose a reason for hiding this comment

thaJeztah Dec 19, 2018

Choose a reason for hiding this comment

thaJeztah commented Dec 19, 2018

thaJeztah left a comment

Choose a reason for hiding this comment

thaJeztah left a comment

Choose a reason for hiding this comment

vdemeester commented Feb 16, 2018 •

edited

Loading

codecov-io commented Feb 16, 2018 •

edited

Loading

dnephin commented Feb 16, 2018 •

edited

Loading

vdemeester commented Feb 22, 2018 •

edited

Loading

vdemeester commented May 18, 2018 •

edited

Loading