Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

better diagnostic message on network label mismatch #10639

Merged
merged 1 commit into from
Jun 5, 2023
Merged

better diagnostic message on network label mismatch #10639

merged 1 commit into from
Jun 5, 2023

Conversation

ndeloof
Copy link
Contributor

@ndeloof ndeloof commented Jun 1, 2023

What I did
this is a follow-up after #10612
improve error message when detected network has incorrect project label

@ndeloof
better diagnostic message on network label mismatch
4312f25 
Signed-off-by: Nicolas De Loof <nicolas.deloof@gmail.com>
@ndeloof ndeloof requested review from a team, nicksieger, StefanScherer, ulyssessouza, glours and milas and removed request for a team June 1, 2023 07:05
@codecov
Copy link

codecov bot commented Jun 1, 2023 •
edited
Loading

Codecov Report

Patch coverage: 16.66% and project coverage change: +0.01 🎉

Comparison is base (1bd8a77) 59.20% compared to head (4312f25) 59.21%.

Additional details and impacted files 
@@            Coverage Diff             @@
##               v2   #10639      +/-   ##
==========================================
+ Coverage   59.20%   59.21%   +0.01%     
==========================================
  Files         107      107              
  Lines        9466     9470       +4     
==========================================
+ Hits         5604     5608       +4     
  Misses       3281     3281              
  Partials      581      581
Impacted Files Coverage Δ
pkg/compose/create.go 58.90% <16.66%> (+0.16%) ⬆️

... and 4 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

milas
milas approved these changes Jun 2, 2023
View reviewed changes
Copy link
Contributor

@milas milas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hurray for friendl(ier) errors!

@ndeloof ndeloof merged commit 629c9f6 into docker:v2 Jun 5, 2023
@ndeloof ndeloof deleted the network_conflict_message branch June 5, 2023 14:55
@danie-dejager danie-dejager mentioned this pull request Jul 10, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@milas milas milas approved these changes

@glours glours glours approved these changes

@nicksieger nicksieger Awaiting requested review from nicksieger nicksieger was automatically assigned from docker/compose-maintainers

@StefanScherer StefanScherer Awaiting requested review from StefanScherer StefanScherer was automatically assigned from docker/compose-maintainers

@ulyssessouza ulyssessouza Awaiting requested review from ulyssessouza ulyssessouza was automatically assigned from docker/compose-maintainers

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ndeloof @glours @milas