ci: speed up a couple Dockerfile targets w/ cache mount #10793
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
milas
requested review from
nicksieger,
ndeloof,
StefanScherer,
ulyssessouza,
glours and
laurazard
and removed request for
a team
|
@milas is your DCO issue back? 😅 |
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## v2 #10793 +/- ##
==========================================
+ Coverage 59.15% 59.28% +0.13%
==========================================
Files 115 115
Lines 9869 9869
==========================================
+ Hits 5838 5851 +13
+ Misses 3438 3428 -10
+ Partials 593 590 -3 ☔ View full report in Codecov by Sentry. |
The local Go package module path was missing from a couple of jobs, which made them slower than needed since they were re-downloading a bunch of dependencies. In particular, this makes `make lint` waaaay faster! Signed-off-by: Milas Bowman <milas.bowman@docker.com>
milas
force-pushed
the
dockerfile-cache-mounts
branch
from
dff58d7
to
1964693
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
The local Go package module path was missing from a couple of jobs, which made them slower than needed since they were re-downloading a bunch of dependencies.
In particular, this makes
make lintwaaaay faster!(not mandatory) A picture of a cute animal, if possible in relation to what you did
