watch: add end-to-end test #10801
Merged
watch: add end-to-end test #10801
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add an end-to-end test that covers the core watch functionality, i.e. CRUD on files & directories. Signed-off-by: Milas Bowman <milas.bowman@docker.com>
milas
requested review from
nicksieger,
ndeloof,
StefanScherer,
ulyssessouza,
glours and
laurazard
and removed request for
a team
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## v2 #10801 +/- ##
=======================================
Coverage 59.24% 59.24%
=======================================
Files 115 115
Lines 9869 9869
=======================================
Hits 5847 5847
Misses 3431 3431
Partials 591 591 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
Add an end-to-end test that covers the core watch functionality, i.e. CRUD on files & directories.
Related issue
This PR will need to be rebased after the following fix is merged or the test won't pass on macOS, as it relies on using a temporary directory:
(not mandatory) A picture of a cute animal, if possible in relation to what you did
