Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

warn user secret uid/gid/mode is not supported #10904

Merged
merged 1 commit into from
Aug 16, 2023

Conversation

ndeloof
Copy link
Contributor

@ndeloof ndeloof commented Aug 16, 2023

What I did
warn user who configured secret/config uid|gid|mode that this isn't supported and won't apply to bind-mounted file

Related issue
closes #10903
(not actually a fix, but we already have #9648 to track this missing feature)

(not mandatory) A picture of a cute animal, if possible in relation to what you did

Signed-off-by: Nicolas De Loof <nicolas.deloof@gmail.com>
@codecov
Copy link

codecov bot commented Aug 16, 2023

Codecov Report

Patch coverage: 50.00% and project coverage change: -0.04% ⚠️

Comparison is base (8d0df18) 58.84% compared to head (7b8a2af) 58.81%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #10904      +/-   ##
==========================================
- Coverage   58.84%   58.81%   -0.04%     
==========================================
  Files         120      120              
  Lines       10470    10476       +6     
==========================================
  Hits         6161     6161              
- Misses       3711     3714       +3     
- Partials      598      601       +3     
Files Changed Coverage Δ
pkg/compose/create.go 59.24% <50.00%> (-0.06%) ⬇️

... and 3 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@milas milas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ndeloof ndeloof merged commit 150449b into docker:main Aug 16, 2023
25 checks passed
@ndeloof ndeloof deleted the warn_secret_uid branch August 17, 2023 07:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Options uid and gid in configs section of service just... Don't work?
2 participants