Update compose_up.md #11150
Closed
Update compose_up.md #11150
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Compose from --> Compose of Signed-off-by: lixin18 <68135097+lixin963@users.noreply.github.com>
|
@aevesdocker does this make sense ? (not being a native english speaker I can't tell :P) |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #11150 +/- ##
==========================================
- Coverage 57.42% 57.33% -0.09%
==========================================
Files 129 129
Lines 11299 11299
==========================================
- Hits 6488 6478 -10
- Misses 4182 4190 +8
- Partials 629 631 +2 ☔ View full report in Codecov by Sentry. |
|
@ndeloof I can state that grammatically the PR is wrong. You prevent something from happening, not something of happening. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Compose from --> Compose of
What I did
Related issue
(not mandatory) A picture of a cute animal, if possible in relation to what you did