Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

--with-dependencies let docker compose build build dependencies transitively #11290

Merged
merged 1 commit into from
Dec 20, 2023

Conversation

ndeloof
Copy link
Contributor

@ndeloof ndeloof commented Dec 20, 2023

What I did
introduce --with-dependencies flag so docker compose build will also build dependencies transitively

Related issue
closes #11275

(not mandatory) A picture of a cute animal, if possible in relation to what you did

@ndeloof ndeloof requested review from a team, glours and milas and removed request for a team December 20, 2023 14:22
Signed-off-by: Nicolas De Loof <nicolas.deloof@gmail.com>
Copy link
Contributor

@glours glours left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

codecov bot commented Dec 20, 2023

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (aefc2a1) 56.24% compared to head (99bf9bf) 56.28%.

Files Patch % Lines
pkg/compose/build.go 40.00% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #11290      +/-   ##
==========================================
+ Coverage   56.24%   56.28%   +0.03%     
==========================================
  Files         134      134              
  Lines       11604    11610       +6     
==========================================
+ Hits         6527     6535       +8     
+ Misses       4427     4425       -2     
  Partials      650      650              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ndeloof ndeloof merged commit 17da54d into docker:main Dec 20, 2023
28 checks passed
@ndeloof ndeloof deleted the build-deps branch December 20, 2023 14:58
matt9ucci added a commit to matt9ucci/DockerCompletion that referenced this pull request Apr 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add option to build dependencies to docker compose build
2 participants