-
Notifications
You must be signed in to change notification settings - Fork 5.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pull: include error message in warnings/errors #11555
Conversation
I wonder we could use |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #11555 +/- ##
==========================================
+ Coverage 54.76% 58.34% +3.58%
==========================================
Files 145 135 -10
Lines 12585 11557 -1028
==========================================
- Hits 6892 6743 -149
+ Misses 5000 4149 -851
+ Partials 693 665 -28 ☔ View full report in Codecov by Sentry. |
@ndeloof I added some code for the unwrapping. This specific message needs to be unpacked at least twice, only unpacking once yields exactly the same output. |
@ndeloof is there a chance to get this actually merged? |
Signed-off-by: Felix Fontein <felix@fontein.de>
Signed-off-by: Felix Fontein <felix@fontein.de>
1ed5572
to
6274fe9
Compare
@ndeloof thanks a lot for reviewing and merging this! |
What I did
When warnings or errors happen during pulling when running
docker compose up
, simply "<service_name> Warning" resp. "<service_name> Error" is printed without any information on what went wrong.This PR changes this by adding the error message.
Before:
After:
Related issue
Ref: ansible-collections/community.docker#807
(not mandatory) A picture of a cute animal, if possible in relation to what you did