Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump Golang version to v1.22.10 and update CI actions #12399

Merged
merged 1 commit into from
Dec 18, 2024

Conversation

glours
Copy link
Contributor

@glours glours commented Dec 18, 2024

What I did
Bump Golang to v1.22.10 and update the different GitHub actions

Related issue

(not mandatory) A picture of a cute animal, if possible in relation to what you did

@glours glours self-assigned this Dec 18, 2024
uses: tibdex/github-app-token@v1
uses: tibdex/github-app-token@v2
Copy link
Member

@thaJeztah thaJeztah Dec 18, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a 3rd party action, so potentially less "trusted"; wondering if this is one that we should pin to a commit? (also make sure that we evaluate the changes in the release).

Diff since last (v1.9.0) v1 release (but perhaps there's been other v1 updates since it was added); tibdex/github-app-token@v1.9.0...v2.1.0

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I pinned the version to the v2.1.0 commit

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@glours glours force-pushed the update-ci-deps branch 2 times, most recently from 802b2a5 to 16ac8d1 Compare December 18, 2024 13:54
Signed-off-by: Guillaume Lours <705411+glours@users.noreply.github.com>
@glours glours requested review from a team and ndeloof and removed request for a team December 18, 2024 14:41
Comment on lines -144 to +146
- 24.0.9
- 25.0.5
- 26.1.4
- 27.4.0-rc.4
- 27.4.1
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just had a check if the script would be fine with that, but it looks like it is; it's possible to specify just 27.4 or even just 27, and it will pick the latest 27.4.x or 27.x.x. That may be ok to consider to not having to update for each minor or patch release.

I'll also check with @vvoland and @crazy-max to see if we can swap this out for our new docker-setup-action (https://github.com/docker/setup-docker-action), but that can definitely wait for separate for sure!

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, it should work! It also supports master (with type=image,tag=master) so it could also be tested against here.

Copy link
Member

@thaJeztah thaJeztah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (if green)

@ndeloof ndeloof enabled auto-merge (rebase) December 18, 2024 15:08
@glours glours disabled auto-merge December 18, 2024 15:09
@glours glours merged commit a42a04d into docker:main Dec 18, 2024
26 checks passed
@glours glours deleted the update-ci-deps branch December 18, 2024 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants