remove exit code per error type used by legacy metrics system #12502
+14
−228
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ndeloof
force-pushed
the
metrics_error
branch
3 times, most recently
from
bc4a15a to
4230b2f
Compare
Signed-off-by: Nicolas De Loof <nicolas.deloof@gmail.com>
ndeloof
force-pushed
the
metrics_error
branch
from
4230b2f to
6f9a67e
Compare
Benehiko
reviewed
Jan 28, 2025
There was a problem hiding this comment.
Wouldn't some scripts rely on the custom exit code?
On another note: I see compose is using the cli.StatusError type directly which won't be possible after this is merged docker/cli#5666
|
@Benehiko docker/cli#5666 will require some adjustment effort as we bump dependency |
glours
approved these changes
Jan 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
removed custom exit code used to distinguish error cause and collect metrics by the legacy compose-cli
Related issue
(not mandatory) A picture of a cute animal, if possible in relation to what you did