Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GH-7397: Handle symlinked Dockerfiles #7413

Closed
wants to merge 1 commit into from

Conversation

Code0x58
Copy link

Resolves #7397

@Code0x58 Code0x58 marked this pull request as draft April 29, 2020 22:20
Signed-off-by: Oliver Bristow <evilumbrella+github@gmail.com>
@thaJeztah
Copy link
Member

Thanks! Looking at my steps trying to reproduce the problem (see #7397 (comment)), I'm actually wondering if this should be fixed in docker-compose; I'm thinking this should be fixed in the docker cli (or in buildkit), and docker-compose should pass the dockerfile path as-is (leaving the handling to the CLI)

@Code0x58
Copy link
Author

Nice drill-down! I like the idea of it being cleaned up and handled in the CLI, it sounds like it could touch a lot of complements - I'm certainly interested to see how it's managed.

I'm wondering if this PR would find it's way in as a workaround at the docker-compose level, until changes are made to the CLI (and python library?), then here would need updating again.

@glours
Copy link
Contributor

glours commented Jul 27, 2022

Thanks for taking the time to create this issue/pull request!

Unfortunately, Docker Compose V1 has reached end-of-life and we are not accepting any more changes (except for security issues). Please try and reproduce your issue with Compose V2 or rewrite your pull request to be based on the v2 branch and create a new issue or PR with the relevant Compose V2 information.

@glours glours closed this Jul 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

docker-compose up fails with symlinked Dockerfile
4 participants