Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: respect dependency order for classic builder #9587

Merged
merged 2 commits into from
Jun 24, 2022

Conversation

milas
Copy link
Contributor

@milas milas commented Jun 22, 2022

What I did
When using the "classic" (non-BuildKit) builder, ensure that
services are iterated in dependency order for a build so that
it's possible to guarantee the presence of a base image that's
been added as a dependency with depends_on. This is a very
common pattern when using base images with Compose.

A fix for BuildKit is blocked currently until we can rely on a
newer version of the engine (see #9324).

Related issue

(not mandatory) A picture of a cute animal, if possible in relation with what you did
American mink

When using the "classic" (non-BuildKit) builder, ensure that
services are iterated in dependency order for a build so that
it's possible to guarantee the presence of a base image that's
been added as a dependency with `depends_on`. This is a very
common pattern when using base images with Compose.

A fix for BuildKit is blocked currently until we can rely on a
newer version of the engine (see docker#9324)[^1].

[^1]: docker#9232 (comment)

Signed-off-by: Milas Bowman <milas.bowman@docker.com>
@milas milas requested a review from a team June 22, 2022 20:28
@milas milas self-assigned this Jun 22, 2022
Copy link
Contributor

@glours glours left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

You just need to add the license header to the 2 Dockerfile you added 😉

@glours glours enabled auto-merge June 24, 2022 09:13
Signed-off-by: Milas Bowman <milas.bowman@docker.com>
@glours glours merged commit 2cd9c0d into docker:v2 Jun 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants