-
Notifications
You must be signed in to change notification settings - Fork 175
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release target with checksums #237
Conversation
Codecov Report
@@ Coverage Diff @@
## master #237 +/- ##
=======================================
Coverage 55.25% 55.25%
=======================================
Files 9 9
Lines 666 666
=======================================
Hits 368 368
Misses 255 255
Partials 43 43 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
one last nit, but otherwise looks good
Signed-off-by: CrazyMax <crazy-max@users.noreply.github.com>
Signed-off-by: CrazyMax <crazy-max@users.noreply.github.com>
Signed-off-by: CrazyMax <crazy-max@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
One difference with the previous releases is that previously we used a
I wasn't sure it the old ones were dynamically linked, but looks like
On debian:bullseye;
On debian:buster;
There is a difference in both though on what it's linked against; what distro and libc does it require? |
Merge release targets in Makefile to a single one called
release
. Also create checksums and update build workflow to publish artifacts to GitHub Release on push tag.Also adds extra commit to remove CHANGELOG as it's outdated and now part of GitHub Releases.
Signed-off-by: CrazyMax crazy-max@users.noreply.github.com