Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix build status badge being broken #252

Merged
merged 1 commit into from
Jan 30, 2023
Merged

Fix build status badge being broken #252

merged 1 commit into from
Jan 30, 2023

Conversation

okrc
Copy link
Contributor

@okrc okrc commented Jan 22, 2023

Copy link
Member

@crazy-max crazy-max left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks

@codecov-commenter
Copy link

codecov-commenter commented Jan 22, 2023

Codecov Report

Base: 55.55% // Head: 55.55% // No change to project coverage 👍

Coverage data is based on head (681aeee) compared to base (ac5992b).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #252   +/-   ##
=======================================
  Coverage   55.55%   55.55%           
=======================================
  Files           9        9           
  Lines         666      666           
=======================================
  Hits          370      370           
  Misses        253      253           
  Partials       43       43           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@crazy-max
Copy link
Member

https://github.com/docker/docker-credential-helpers/actions/runs/3977887729/jobs/6825115357#step:4:383

 > [vendor-validate 1/1] RUN --mount=type=bind,target=.,rw <<EOT (set -e...):
#0 0.072 rsync: [sender] change_dir "/context" failed: No such file or directory (2)
#17 0.194 rsync error: some files/attrs were not transferred (see previous errors) (code 23) at main.c(1333) [sender=3.2.3]

Not related to this change but needs to be fixed in follow-up

Signed-off-by: okrc <okrc@hexo.dev>
@crazy-max crazy-max merged commit d783511 into docker:master Jan 30, 2023
@okrc okrc deleted the patch-1 branch February 1, 2023 02:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants