Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

windows/arm64 support for wincred #279

Merged
merged 1 commit into from
May 27, 2023
Merged

Conversation

crazy-max
Copy link
Member

No description provided.

Signed-off-by: CrazyMax <crazy-max@users.noreply.github.com>
@codecov-commenter
Copy link

codecov-commenter commented May 27, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (9ff5b61) 55.55% compared to head (88cb947) 55.55%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #279   +/-   ##
=======================================
  Coverage   55.55%   55.55%           
=======================================
  Files           9        9           
  Lines         666      666           
=======================================
  Hits          370      370           
  Misses        253      253           
  Partials       43       43           

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@thaJeztah
Copy link
Member

Looks like it's green; ready for review?

@crazy-max crazy-max marked this pull request as ready for review May 27, 2023 16:56
@crazy-max crazy-max requested a review from thaJeztah May 27, 2023 16:56
@crazy-max
Copy link
Member Author

Looks like it's green; ready for review?

Yes I was making some tests on Windows 11 Aarch64 machine

Copy link
Member

@thaJeztah thaJeztah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@thaJeztah thaJeztah merged commit ec695ce into docker:master May 27, 2023
@crazy-max crazy-max deleted the win-arm64 branch May 27, 2023 18:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants