-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix secret repr #2470
Fix secret repr #2470
Conversation
Please sign your commits following these rules: $ git clone -b "fix-secret-repr" git@github.com:feliperuhland/docker-py.git somewhere
$ cd somewhere
$ git rebase -i HEAD~842354499952
editor opens
change each 'pick' to 'edit'
save the file and quit
$ git commit --amend -s --no-edit
$ git rebase --continue # and repeat the amend for each commit
$ git push -f Amending updates the existing PR. You DO NOT need to open a new one. |
514bfd0
to
63dfad4
Compare
- a post fake secret - added to fake api - create a unit test Signed-off-by: Felipe Ruhland <felipe.ruhland@gmail.com>
63dfad4
to
7750c91
Compare
- Change id_attribute to Id - add new property id - add name fallback Fixes docker#2025 Signed-off-by: Felipe Ruhland <felipe.ruhland@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe it would be better to change the repr method than the name getter?
I'm pretty sure that someone using my_secret.name
is not expecting to get an id instead of a name in certain cases.
Thank you, @etienne-napoleone. I changed the repr in c5f3376 |
fd66de0
to
c5f3376
Compare
Signed-off-by: Felipe Ruhland <felipe.ruhland@gmail.com>
Seems like a CI problem. Is there a way to run it again? |
This PR fixes issue #2025