copy deprecated splitnport from stdlib Fixes #2566 #2567
Conversation
| Return numerical port if a valid number are found after ':'. | ||
| Return None if ':' but not a valid number. | ||
|
|
||
| From https://github.com/python/cpython/blob/3.8/Lib/urllib/parse.py |
There was a problem hiding this comment.
is this code long enough to need a licence declaration? Imho it's fair use
There was a problem hiding this comment.
No really familiar with the Python license, but reading https://github.com/python/cpython/blob/v3.8.3/LICENSE#L74-L84
provided, however, that PSF's License Agreement and PSF's notice of copyright,
i.e., "Copyright (c) 2001, 2002, 2003, 2004, 2005, 2006, 2007, 2008, 2009, 2010,
2011, 2012, 2013, 2014, 2015, 2016, 2017, 2018, 2019, 2020 Python Software Foundation;
All Rights Reserved" are retained in Python alone or in any derivative version
prepared by Licensee.
Perhaps it should be mentioned, just to be on the safe side (I guess using a range for the years to keep it a bit shorter would be ok though) 🤔
It's also better to link to a tag here instead of a release-branch (release branches could potentially be removed, which is less likely for tags). Perhaps link to the actual lines while doing so;
Based on https://github.com/python/cpython/blob/v3.8.3/Lib/urllib/parse.py#L1094-L1108
Copyright (c) 2001-2020 Python Software Foundation; All Rights ReservedThere was a problem hiding this comment.
@thaJeztah can you make this as a GitHub ```suggestion?
There was a problem hiding this comment.
Oh, I avoided doing that, because overall we prefer changes to be grouped in logical commits (so no "touch-up" commits if not needed) 😅
Signed-off-by: Thomas Grainger <tagrain@gmail.com>
|
@ulyssessouza PTAL |
|
Hi! Sorry we never got this PR over the finish line before 😓 I'm going to close this one because unfortunately there's been a lot of repo churn since this was opened, so it's no longer valid with CI, and additionally, there were actually other bugs as a result of our usage of Thanks for your contribution and time! |
No description provided.